[openib-general] svn patches.

Wed Apr 28 14:46:35 PDT 2004

Hm, looks like my patch never made it through the list, anyone know what
the max size of an email for the list is?  All I did was reformat 2
files :)

Anyway, a more basic question:

On Wed, Apr 28, 2004 at 02:36:26PM -0700, Greg KH wrote:
>         /*
>      * Find a HCA on the PCI bus
>      */
> -   hca_pdev = pci_find_device(0x15b3,0x5a46,NULL);
> -    if (hca_pdev == NULL) {
> -       hca_pdev = pci_find_device(0x1867,0x5a46,NULL);
> -    }
> -    if (hca_pdev == NULL) {
> +   hca_pdev = pci_find_device(0x15b3, 0x5a46, NULL);
> +   if (hca_pdev == NULL) {
> +           hca_pdev = pci_find_device(0x1867, 0x5a46, NULL);
> +   }
> +   if (hca_pdev == NULL) {

Hahaha, you all only support 2 devices?  And it's either 1 or the other?
What about more than 1 controller in a system at the same time?  What
about PCI hotplug systems?  This code is guaranteed to do very bad
things to the system if someone removes the controller while the driver
is still bound.

How about a hint as to what these pci ids are for?

Want me to port this to the proper api?

Also it doesn't look like you really cleanup at all if the pci device is
not found.  Why keep everything initialized and up and running if there
is no device in the system?

thanks,

greg k-h

-- 
To unsubscribe send an email with subject unsubscribe to openib-general at openib.org.
Please contact moderator at openib.org for questions.