[openib-general] [PATCH] ib_mad: In completion handler, when status != success call send done handler

Thu Oct 28 07:42:23 PDT 2004

On Thu, 2004-10-28 at 02:01, Sean Hefty wrote:
> I've run into a few other issues trying to use separate send queues. 
> One of note is that receives are posted to the QP outside of the lock
> that inserts them onto the recv_posted_mad_list.

I couldn't find where you were referring to. Can you point me at it ?

> I don't think that this causes a problem at the moment, since receives are 
> always re-posted from the completion handler, which is single threaded.
> 
> Question then, should I go ahead and fix this so that it would work in a
> multi-threaded case, or assume that completion handling will be single
> threaded and optimize for this by removing unnecessary locking?

Also, if this is locked, should we go to finer grained locks ? Currently
there is a lock for the receive list, but might a lock per receive list
per QP be better ?

> (Currently, my patch fixes the locking, but it should be noted that the
> code won't actually test that the locking is correct as it's written.)

I guess we'll just do it by code inspection or someone should develop
test(s) or real case(s) for this.

-- Hal