[openib-general] [PATCH] ib_mad: In completion handler, when status != success call send done handler

Sean Hefty
Wed Oct 27 14:42:17 PDT 2004


On Tue, 26 Oct 2004 13:14:00 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> On Tue, 2004-10-26 at 13:10, Roland Dreier wrote:
> >     Sean> As a suggestion, we can allocate 2 CQs per QP, one for
> >     Sean> receives, and one for sends.  This would let us separate
> >     Sean> send from receive completions based on the callback.
> > 
> > That's one solution, and another way to handle it is to have a way
> > of distinguishing sends from receives based on wr_id (that's what
> > the Topspin stack does).
> 
> That's where I was heading with this. It implies a "stolen" bit in the
> WRID.
> 
> > Not sure which is better really.
> 
> Me neither but Sean seems to feel strongly about the CQ separation.

Just to make sure that we don't have duplicate efforts, I've been
working on the patch to fix handling of send completions.  My plan is to
use one send_mad_posted_list per QP, to make it faster/easier to find
the correct send completion, plus allow for easier error handling when
one of the special QPs goes into the error state.

The code currently maintains a single CQ per port.

- Sean


More information about the openib-general mailing list