[openib-general] agent_mad_send

Wed Oct 27 09:47:53 PDT 2004

On Wed, 27 Oct 2004 09:47:25 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> On Tue, 2004-10-26 at 18:29, Sean Hefty wrote:
> > In agent_mad_send, a call is made to create an address handle.  
> > Immediately after calling ib_post_send_mad, the address handle is destroyed.  
> > I think that we want to wait until the send is completed before destroying 
> > the address handle, and require this of all callers of ib_post_send_mad.
> 
> I can post a patch for this but this depends on whether the agent or MAD
> layer should destroy the AH.

I think that the MAD agent should, since it allocated the AH.

> > Also, I don't think that we want to have this code access the port_priv 
> > structure, such as the send_list_lock (which ends up being acquired twice).
> 
> The agent is using a different port_priv structure and send_list_lock
> than the one the MAD layer uses. Where is it acquired twice ?

My bad.  I was working off of the variable names, and didn't check that they had different types.

- Sean

-- 