[openib-general] [PATCH] Combine ib_agent into ib_mad module

Tue Oct 26 10:36:24 PDT 2004

On Tue, 2004-10-26 at 13:13, Roland Dreier wrote:
>     Hal> Combine ib_agent into ib_mad module
> 
> Why did you use this approach (move ib_agent_port_{open,close} into
> ib_mad.c) rather than the more minimal way I posted, that just had
> ib_mad.c register the ib_agent_client?

Because with just your changes, the port did not become active. It
appeared that there needed to be some synchronization between the MAD
layer completing its initialization and the agents completing theirs.
This was the simplest way I could think of. I'm sure there are other
solutions too.

Also, while your changes were fewer lines of code change, these changes
are less lines of code total. Is there an issue with doing it this way ?

>     Hal> The only downside of this
>     Hal> currently is that when removing some module which uses the AL
>     Hal> will cause the AL to be removed. Is there a way to stop a
>     Hal> dependency from unloading ?
> 
> Does it work for you to use rmmod instead of 'modprobe -r'?  

Yes. I forgot about rmmod... Maybe we will need to FAQ this.

> In any case if nothing depends on the MAD module why does it have to stay
> loaded?

Because the agents need to stay around or the port does not stay active
now.

-- Hal