[openib-general] [PATCH] ib_mad: In completion handler, when status != success call send done handler

Tue Oct 26 09:50:09 PDT 2004

On Tue, 26 Oct 2004 12:44:56 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> On Tue, 2004-10-26 at 12:30, Sean Hefty wrote:
> > > I think this is still not quite right: what if a receive fails?
> > 
> > As a suggestion, we can allocate 2 CQs per QP, one for receives, 
> > and one for sends.  This would let us separate send from receive 
> > completions based on the callback.
> 
> Another alternative is to assume it is a receive if it is not a send is
> not matched.

I think we have other issues with the completion handling as well.  Since we use a single CQ for both QPs, I think that we need to search the send_posted_mad_list to find the corresponding completion.  We cannot assume that the completion matches with the request at the head of the list.

This appears to be broken in the non-error case as well.

I will happily create a patch to fix these issues.

- Sean