[openib-general] Re: [PATCH] for review to timeout send MADs

Thu Oct 7 07:28:10 PDT 2004

On Wed, 2004-10-06 at 19:01, Sean Hefty wrote:
> Here are some modifications to support timing out send MADs in 
> the access layer.  I haven't tested this code beyond building it, 

Is this still the case ? I noticed you burning the midnight oil last
night :-)

> but wanted to make it available for review.  There are a few race 
> conditions that need to be avoided when handling timeouts, so if 
> it looks like something was missed, let me know.

If it is not too much work, I would prefer this broken into 2 patches:
the first on variable name changes, common error exiting, etc. (all the
changes not related to the addition of the timeout functionality) and a
second with just the timeout functionality.

> Hal, can you either send me your test code or check it into svn 
> somewhere?  I want to verify that this doesn't break your current 
> tests, then expand the tests to check that the timeout code is 
> working properly.

This test code currently relies on a GSM generating a request in order
to reflect the request back. Is that useful to you ?

If so, I will post it to this list will integrate it into the tree and
the build process such that it does not get included with the normal
Linux source.

-- Hal 