[openib-general] [PATCH] ib_mad.h: Remove network endianconversionof QP1 QKey

Wed Oct 6 10:23:16 PDT 2004

>On Wed, 2004-10-06 at 12:46, Fab Tillier wrote:
>> > From: Hal Rosenstock [mailto:halr at voltaire.com]
>> > Sent: Wednesday, October 06, 2004 9:42 AM
>> >
>> > ib_mad.h: Remove network endian conversion of QP1 QKey
>>
>> I don't get the point.  Is IB_QP1_QKEY going to be treated in host order,
>> and then swapped by someone at some point when posting?  Does mthca
>expect
>> the QKey to be provided in host order and then swap it when formatting
>the
>> WQEs?
>
>In ib_mad.c, it's used as a QKey attribute to the HCA when the QP is
>initialized.
>
>In a client, it's used as the remote QKey in the send WR ud request.
>
>The only byte swapping is done by the HCA not in the MAD layer or
>client.

Mthca performs byte-swapping on the qkey in both of these cases.

At this point, I think the openib stack needs byte-ordering reworked, but it
can probably wait.